[ACCEPTED]-C# - StreamReader.ReadLine does not work properly!-bufferedstream

Accepted answer

Score: 16

A typical line-reader is something like:

using(StreamReader reader = new StreamReader(Socket.GetStream(), Encoding.UTF8)) {
    string line;
    while((line = reader.ReadLine()) != null) {
        // do something with line
    }
}

(note 14 the using to ensure we Dispose() it even if we get an 13 error, and the loop)

If you want, you could 12 abstract this (separation of concerns) with 11 an iterator block:

static IEnumerable<string> ReadLines(Stream source, Encoding encoding) {
    using(StreamReader reader = new StreamReader(source, encoding)) {
        string line;
        while((line = reader.ReadLine()) != null) {
            yield return line;
        }
    }
}

(note we've moved this 10 into a function and removed the "do something", replacing 9 it with "yield return", which creates an 8 iterator (a lazily iterated, non-buffering 7 state machine)

We would then consume this 6 as simply as:

foreach(string line in ReadLines(Socket.GetStream(), Encoding.UTF8)) {
    // do something with line
}

Now our processing code doesn't 5 need to worry about how to read lines - simply 4 given a sequence of lines, do something with 3 them.

Note that the using (Dispose()) applies to TcpClient too; you 2 should make a habit of checking for IDisposable; for 1 example (still including your error-logging):

using(TcpClient tcpClient = new TcpClient()) {
    try {
       tcpClient.Connect("localhost", serverPort);
       StreamWriter writer = new StreamWriter(tcpClient.GetStream(), Encoding.UTF8);
       writer.AutoFlush = true;
       writer.WriteLine("login>user,pass");
       writer.WriteLine("print>param1,param2,param3");
    } catch (Exception ex) {
        Console.Error.WriteLine(ex.ToString());
    }
}

Score: 5

The while in your server code is setup to 8 only read one line per connection. You'll 7 need another while within the try to read 6 all of the lines being sent. I think once 5 that stream is setup on the client side, it 4 is going to send all of the data. Then 3 on the server side, your stream is effectively 2 only reading one line from that particular 1 stream.

Score: 0

    public string READS()
    {
        byte[] buf = new byte[CLI.Available];//set buffer
        CLI.Receive(buf);//read bytes from stream
        string line = UTF8Encoding.UTF8.GetString(buf);//get string from bytes
        return line;//return string from bytes
    }
    public void WRITES(string text)
    {
        byte[] buf = UTF8Encoding.UTF8.GetBytes(text);//get bytes of text
        CLI.Send(buf);//send bytes
    }

CLI is a socket. for some rezone the TcpClient 3 class doesn't work right on my pc any more, but 2 the Socket class works just fine.

UTF-8 is 1 the stranded StreamReader / Writer Encoding

Source: stackoverflow.com

[ACCEPTED]-C# - StreamReader.ReadLine does not work properly!-bufferedstream

Adding a Line to the Middle of a File with .NET

Reading and writing very large text files in C#

StreamReader.ReadLine will hang in an infinite loop

How to know position(linenumber) of a streamreader in a textfile?

simultaneous read-write a file in C#

Extracting the first 10 lines of a file to a string

Unable to read data from the transport connection: The connection was closed error in console application

What are the default values for StreamReader?

Using StreamReader.ReadLine in loop only reads one line from text file

What is the purpose of StreamReader when Stream.Read() exists?